Welcome
Welcome to refracta

You are currently viewing our boards as a guest, which gives you limited access to view most discussions and access our other features. By joining our free community, you will have access to post topics, communicate privately with other members (PM), respond to polls, upload content, and access many other special features. In addition, registered members also see less advertisements. Registration is fast, simple, and absolutely free, so please, join our community today!

Installer option: "Do not format"

Refracta Development, Scripts, etc.

Re: Installer option: "Do not format"

Postby fsmithred » Thu Oct 24, 2013 3:22 pm

I don't think it matters whether the label shows up at the beginning or end of the line. The first way you have it is correct:
Code: Select all
blkid -c /dev/null -s LABEL
The second way is incorrect. (doesn't matter if you use the full path or not, since root is running it.)

What I found (before I posted earlier) is that blkid.tab doesn't get the label updated (removed) when you run mke2fs and don't set a new label. The uuid and the filesystem type do get updated. Running 'blkid -c /dev/null' gives the updated information.
User avatar
fsmithred
 
Posts: 2101
Joined: Wed Mar 09, 2011 9:13 pm

Re: Installer option: "Do not format"

Postby ukbrian » Sat Oct 26, 2013 1:52 pm

I gave the labels another go using UUID for fstab but same result.
When the blkid window comes up when your selecting a partition it shows the label as existing but after installing if I run sudo blkid -c /dev/null while still in the live CD the label does not exist.

Looking at the mke2fs lines I can't see where the label is added?

I can comment out the mke2fs line to retain the label but it seems much neater to format the partition.

When I take a snapshot it is not counting existing snapshots, it always shows 0 but the size taken is correct.

edit
I just done a fresh install with line 923 commented out and the label is retained, everything is good.
# mke2fs -t $fs_type_os "$install_part" ; check_exit
I can't see where you add the label to install-part?
User avatar
ukbrian
 
Posts: 109
Joined: Mon Jul 25, 2011 8:22 am
Location: Cheltenham, UK

Re: Installer option: "Do not format"

Postby fsmithred » Sat Oct 26, 2013 5:38 pm

The label gets removed when you run mke2fs.I believe this was the problem that golinux had a few months ago. She formatted the partitions in gparted and gave them labels, but then the labels were gone at the end of the installation. In the previous installers, if you selected to use labels, you would be asked to supply the label, and it would be added with e2label. (In the section that starts at line 1094)

In the beta installer, there's an option to let the installer know that you're formatting the partitions first, and mke2fs won't run. If you select to use labels in fstab, the installer will do one of two things - if labels exist, it will use them, and if they don't exist, it will ask you to supply them.

The blkid window (an xterm) in the older installers (including current stable version) would not show the changes if you made or changed labels in gparted. The beta should show the true current state with the '-c /dev/null' option. Make sure you're using the yad-based installer, as the zenity-based script hasn't been updated yet.

And you shouldn't need to comment out line 923 anymore (in the beta installer). You can set it in the options. It's option 10, "Do not format filesystems. I'll handle it myself."

Try this - take a partition that has a label and run mke2fs on it. Run 'blkid', and you'll still see the label, because it's still listed in etc/blkid.tab. Run 'blkid -c /dev/null' and you won't see the label, because it doesn't exist. If you want, you can compare this to what you see in /dev/disk/by-label, which does get updated when you add, change or remove a label. (Incidentally, the only way I can figure to remove a label is to format the filesystem.)

I'm aware of the snapshot count registering as zero. Just noticed this in the past few days, and I can't figure it out. I'll probably start a new thread about it.

Edit: No new thread right now. Looks like line 172 of refractasnapshot-gui, in the check_copies function needs to change from this:
Code: Select all
   if [[ -e "$snapshot_dir"/*.iso ]] ; then

to either one of these:
Code: Select all
if ls "$snapshot_dir"/*.iso ; then
if ls "$snapshot_dir"/*.iso > /dev/null ; then
User avatar
fsmithred
 
Posts: 2101
Joined: Wed Mar 09, 2011 9:13 pm

Re: Installer option: "Do not format"

Postby ukbrian » Sat Oct 26, 2013 9:15 pm

Very sorry, I didn't notice the extra entry in the Expert list.
I just did a fresh install and everything works as it should. :D

I honestly think it would be better if you save the existing label in a variable and then format the partition adding the variable as the label as Anthony did, it's one less decision for the user, one less option in the list.

I keep getting error when I preview so I'll try to add with edits
I can't enter slashes without getting a 404
I've found that when I do the label in gparted I edit etc-default-grub and change the
GRUB_DISTRIBUTOR=Refracta-dev1 line to match the directory label so the entry set appears in the grub menu making it a lot easier to identify in grub. I know I do weird things but they work.

I don't know if I'm sticking my nose in where it's not wanted but I've been adding the icons to the windows in the snapshot script, easy to change the icons with a search-replace. http://lin.me.uk/refracta/snapshot.tar.gz

I've only done the main screens not the error ones
User avatar
ukbrian
 
Posts: 109
Joined: Mon Jul 25, 2011 8:22 am
Location: Cheltenham, UK

Re: Installer option: "Do not format"

Postby ukbrian » Sat Oct 26, 2013 9:58 pm

I'm truly stunned by what you've done with the Refracta ISO.
I can't believe how small you've got it, unbelievable

I've been chucking everything at it for 3 days now and it just comes back smiling, no problems whatsoever.

You done good man.

I whittled away at Salineos squeeze 2 years ago to make a rescue ISO for qt4-fsarchiver and it was a real fight to get under 700 MB, Refracta is a breeze.

Many, many congratulations
User avatar
ukbrian
 
Posts: 109
Joined: Mon Jul 25, 2011 8:22 am
Location: Cheltenham, UK

Re: Installer option: "Do not format"

Postby ukbrian » Sun Oct 27, 2013 2:34 pm

Is there any sense in having a variable in refractasnapshot.conf file for the icon like
Code: Select all
window_icon=/usr/share/pixmaps/camera-48.png
So that in the script you would write
Code: Select all
$DIALOG --$QUESTION --title="Disk Space and Settings Report" --window-icon=$WIN-ICON

Just an old man trying to be lazy my friend, medication must be good :D
User avatar
ukbrian
 
Posts: 109
Joined: Mon Jul 25, 2011 8:22 am
Location: Cheltenham, UK

Re: Installer option: "Do not format"

Postby fsmithred » Sun Oct 27, 2013 8:36 pm

I appreciate the effort, but I don't much care about icons in the windows. In fact, I think less stuff in the visual space is better unless it helps the user find the right choice. Figure out how to get the red and green button icons into the custom yad buttons (like the one where you choose where to put grub) and I'll buy you a beer when I'm in your neighborhood.
User avatar
fsmithred
 
Posts: 2101
Joined: Wed Mar 09, 2011 9:13 pm

Re: Installer option: "Do not format"

Postby ukbrian » Sun Oct 27, 2013 10:27 pm

I appreciate the effort, but I don't much care about icons in the windows. In fact, I think less stuff in the visual space is better unless it helps the user find the right choice.
I don't like clutter either but if you don't set it you get the yad icon, a flask containing a green liquid on your screen form and in the panel.

If you don't mind me doing it I'd like to carry on, I'll never be able to do the cmd line code but If I can do a bit with the screen forms it might come in handy one day. I'll have a look at the buttons tomorrow.

I'd like to be able to do more with yad screen forms so the coloured buttons question is perfect for me as I can read but not understand manuals. A perfect excercise you have given me, thank you.

I'll buy you a beer when I'm in your neighborhood.
I was a very, very heavy drinker for all my working life as a travelling roofing contractor but I did cold turkey 20 years ago so I come cheap now, just a cup of tea thanks, or maybe 2 cups . :D

I just gftp to connect so I'm pleased, be interesting to compare with filezilla which I've used previously.

If this was a dark red box instead of black it might be OK for burn ISO screen form.
Image
User avatar
ukbrian
 
Posts: 109
Joined: Mon Jul 25, 2011 8:22 am
Location: Cheltenham, UK

Re: Installer option: "Do not format"

Postby ukbrian » Sun Oct 27, 2013 11:06 pm

I love what golinux did with the web site, maybe find a good icon, preferably not a computor symbol type thing, maybe a horizontal cd with a guy with a pick working on the cd.
User avatar
ukbrian
 
Posts: 109
Joined: Mon Jul 25, 2011 8:22 am
Location: Cheltenham, UK

Re: Installer option: "Do not format"

Postby ukbrian » Mon Oct 28, 2013 12:49 am

Arn't you already doing the colored button thing here? Image
User avatar
ukbrian
 
Posts: 109
Joined: Mon Jul 25, 2011 8:22 am
Location: Cheltenham, UK

PreviousNext

Return to Discuss

Who is online

Users browsing this forum: No registered users and 0 guests

cron
suspicion-preferred